Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the OpenAPI document version from v0.5.9 to v0.5.12, introduces a new export_catalogs API endpoint with its corresponding structures, updates the export_secrets method to use POST with JSON parameters, and adjusts Cargo.toml to use workspace attributes for versioning and metadata.
- Updated API version documentation across files
- Addition of new export_catalogs API and modifications to export_secrets API
- Adjustment of Cargo.toml metadata to align with workspace configuration
Reviewed Changes
Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/tower-api/src/models/*.rs | Updated OpenAPI document version to v0.5.12 in API model comments |
| crates/tower-api/src/apis/default_api.rs | Added export_catalogs API endpoint and updated export_secrets API implementation |
| crates/tower-api/src/apis/configuration.rs | Updated OpenAPI document version to v0.5.12 in configuration documentation |
| crates/tower-api/README.md | Updated API version and documentation references to v0.5.12 |
| crates/tower-api/Cargo.toml | Changed versioning and metadata to use workspace attributes |
Comments suppressed due to low confidence (2)
crates/tower-api/src/apis/default_api.rs:560
- Changing DeleteSecretSuccess from Status204() to Status200 with a response model may affect clients that expect no body in deletion responses. Please confirm that the API design and client contracts have been updated accordingly.
Status200(models::DeleteSecretResponse),
crates/tower-api/src/apis/default_api.rs:2325
- The new export_catalogs endpoint now uses POST with a JSON body instead of a GET request. Please verify that this change aligns with the overall API design and client expectations for catalog exports.
pub async fn export_catalogs(configuration: &configuration::Configuration, params: ExportCatalogsParams) -> Result<ResponseContent<ExportCatalogsSuccess>, Error<ExportCatalogsError>> {
…problems-opening-browser-on-her-windows Fix bug preventing some CLI users from logging in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.